----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5586/#review8607 -----------------------------------------------------------
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java <https://reviews.apache.org/r/5586/#comment18259> This is not required. Unsupervise calls stop() on all components, and stop is what sets the LifecycleState to STOP. So if stop() returns without setting the lifecycle state to STOP, it is a bug. These 2 loops are not required. flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java <https://reviews.apache.org/r/5586/#comment18260> Same as above. - Hari Shreedharan On June 26, 2012, 12:07 p.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5586/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 12:07 p.m.) > > > Review request for Flume. > > > Description > ------- > > Components should be stopped in a basically deterministic order, instead of a > random Map order as they are today. Also, the shutdown code paths for the > reconfiguration and the normal stop should be merged. > > > This addresses bug FLUME-1325. > https://issues.apache.org/jira/browse/FLUME-1325 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java > 7403dd3 > > Diff: https://reviews.apache.org/r/5586/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Mike Percy > >
