[ 
https://issues.apache.org/jira/browse/FLUME-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401936#comment-13401936
 ] 

Mubarak Seyed commented on FLUME-1316:
--------------------------------------

@Will

NettyAvroRpcClient uses two constants

{code}
private final static long DEFAULT_CONNECT_TIMEOUT_MILLIS =
      TimeUnit.MILLISECONDS.convert(60, TimeUnit.SECONDS);

private final static long DEFAULT_REQUEST_TIMEOUT_MILLIS =
      TimeUnit.MILLISECONDS.convert(60, TimeUnit.SECONDS);
{code}

connect() uses DEFAULT_CONNECT_TIMEOUT_MILLIS and append() uses 
DEFAULT_REQUEST_TIMEOUT_MILLIS, looks like both are constants.

Both RpcClient.getDefaultInstance() and AvroSink are making use of 
NettyAvroRpcClient. Which SDK are you referring to? Are you saying that these 
two values are default and config can override? for example

{code}
agent.sinks.avro-sink1.connect-timeout=60
agent.sinks.avro-sink1.request-timeout=60
{code}
                
> AvroSink should be configurable for connect-timeout and request-timeout
> -----------------------------------------------------------------------
>
>                 Key: FLUME-1316
>                 URL: https://issues.apache.org/jira/browse/FLUME-1316
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.2.0
>            Reporter: Will McQueen
>             Fix For: v1.2.0
>
>
> The Flume SDK provides connect-timeout and request-timeout props, but similar 
> props are not currently exposed in AvroSink.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to