This is a gentle reminder. I'd also like to extend the time a week; so
please have your comments and/or approval back to me by Oct 12, 2009.
thx,
-t
Tom Pothier wrote:
Hello,
The updated webrev, with I believe includes all code review comments
to date, is now available:
http://cr.opensolaris.org/~pothier/onnv-x86gentopo-pb-124/
If you do check the webrev and explicitly approve it, please let me
know so I can "truthfully" place a "yes" next to your name on the
C-Team checklist. :-)
Also, mentioned before, we'd like to wrap up the code review cycle by
COB Oct 5, 2009.
thx,
-t
On 09/02/09 12:25, Tom Pothier wrote:
The webrev is now also available on opensolaris.org:
http://cr.opensolaris.org/~pothier/onnv-x86gentopo-pb/
thx,
-t
On 09/02/09 10:27, Tom Pothier wrote:
Hi,
I'd like to invite folks to participate in the code review for the
x86 Generic FMA Topology Enumerator project. I'd like to have
comments back no later than COB on October 5, 2009.
The webrev for Sun internal folks is at:
https://ssg-east.east.sun.com/~pothier/webrevs/onnv-x86gentopo-pb/
I've also placed the code review 'onnv-x86gentopo-pb.pdf' file on
the OpenSolaris project page under the "Documents" heading.
The push will look like this:
changeset: 10254:27683d5d640a
tag: tip
user: Tom Pothier <tom.poth...@sun.com>
date: Tue Sep 01 15:15:19 2009 -0400
description:
PSARC/2009/XXX x86 Generic FMA Topology Enumerator
6841286 Need x86 generic FMA topo enumerator
6853537 x86gentopo needs OEM-Specific SMBIOS structures
6785310 Implement SMBIOS contained elements/handles
6865771 Topology relationships should be derived from
contained handles & elements of SMBIOS
6865814 Chip enumerator should derive serials & labels using
libsmbios, if SMBIOS is FM aware
6865845 /dev/fm should export the Initial APICID, SMBIOS
based ID/instance to the chip enumerator
6866456 Generic Topology FMRI ereport
modified:
usr/src/cmd/fm/eversholt/files/i386/i86pc/intel.esc
usr/src/cmd/mdb/intel/modules/generic_cpu/gcpu.c
usr/src/cmd/smbios/smbios.c
usr/src/common/smbios/smb_info.c
usr/src/common/smbios/smb_open.c
usr/src/lib/fm/topo/libtopo/common/mapfile-vers
usr/src/lib/fm/topo/libtopo/common/topo_mod.map
usr/src/lib/fm/topo/maps/i86pc/Makefile
usr/src/lib/fm/topo/maps/i86pc/i86pc-hc-topology.xml
usr/src/lib/fm/topo/modules/common/pcibus/did_props.c
usr/src/lib/fm/topo/modules/i86pc/Makefile
usr/src/lib/fm/topo/modules/i86pc/chip/Makefile
usr/src/lib/fm/topo/modules/i86pc/chip/chip.c
usr/src/lib/fm/topo/modules/i86pc/chip/chip.h
usr/src/lib/fm/topo/modules/i86pc/chip/chip_amd.c
usr/src/lib/fm/topo/modules/i86pc/chip/chip_intel.c
usr/src/lib/libsmbios/common/mapfile-vers
usr/src/pkgdefs/SUNWfmd/prototype_i386
usr/src/uts/common/io/devfm.c
usr/src/uts/common/os/fm.c
usr/src/uts/common/sys/devfm.h
usr/src/uts/common/sys/fm/protocol.h
usr/src/uts/common/sys/smbios.h
usr/src/uts/common/sys/smbios_impl.h
usr/src/uts/i86pc/cpu/amd_opteron/ao_mca.c
usr/src/uts/i86pc/cpu/authenticamd/authamd_main.c
usr/src/uts/i86pc/cpu/generic_cpu/gcpu_mca.c
usr/src/uts/i86pc/cpu/genuineintel/gintel_main.c
usr/src/uts/i86pc/os/cmi.c
usr/src/uts/i86pc/os/cmi_hw.c
usr/src/uts/i86pc/os/startup.c
usr/src/uts/i86xpv/os/xen_machdep.c
usr/src/uts/intel/Makefile.files
usr/src/uts/intel/io/devfm_machdep.c
usr/src/uts/intel/io/mc-amd/mcamd.h
usr/src/uts/intel/io/mc-amd/mcamd_drv.c
usr/src/uts/intel/io/mc-amd/mcamd_subr.c
usr/src/uts/intel/sys/cpu_module.h
usr/src/uts/intel/sys/hypervisor.h
added:
usr/src/lib/fm/topo/maps/i86pc/i86pc-legacy-hc-topology.xml
usr/src/lib/fm/topo/modules/i86pc/chip/chip_smbios.c
usr/src/lib/fm/topo/modules/i86pc/x86pi/Makefile
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi.c
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi_bboard.c
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi_chassis.c
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi_generic.c
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi_hostbridge.c
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi_impl.h
usr/src/lib/fm/topo/modules/i86pc/x86pi/x86pi_subr.c
usr/src/uts/intel/os/fmsmb.c
usr/src/uts/intel/sys/fm/smb/fmsmb.h
thx,
-t
_______________________________________________
fm-discuss mailing list
fm-discuss@opensolaris.org
_______________________________________________
fm-discuss mailing list
fm-discuss@opensolaris.org
_______________________________________________
fm-discuss mailing list
fm-discuss@opensolaris.org
