https://bugs.webkit.org/show_bug.cgi?id=37984
Martin Robinson <mrobin...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #442519|review? |review-
Flags| |
--- Comment #49 from Martin Robinson <mrobin...@webkit.org> ---
Comment on attachment 442519
--> https://bugs.webkit.org/attachment.cgi?id=442519
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=442519&action=review
This is great! Looks like the test is still failing on Mac and this should
handle a failed call to hb_language_from_string, but this is a good start.
> Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:548
> + hb_language_t language = hb_language_from_string(reinterpret_cast<const
> char*>(m_font.fontDescription().computedLocale().characters8()), -1);
I think it would be better to do this here:
hb_language_from_string(m_font.fontDescription().computedLocale().string().toUTF8().data()),
-1);
This would allow you to avoid the reinterpret_cast.
It seems like this call should check for and handle (not set the language
below) the situation where HB_LANGUAGE_INVALID is returned here.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
fonts-bugs mailing list -- fonts-bugs@lists.fedoraproject.org
To unsubscribe send an email to fonts-bugs-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/fonts-bugs@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
