Patch 5289 is broken for two distinct reasons.  Please don't apply it.

First, it breaks all scalable fonts.  The fix is to make the
``:unscaled'' hack only apply to non-scalable entries (attached purely
for your information -- I don't suggest committing anything in the
current state of the beast).

The second problem is that it breaks subset specifications, which
appear to be handled by the same mechanism as scalable fonts.  I don't
have a fix yet, but it ain't gonna be pretty.

                                        Juliusz

*** xc/lib/font/fontfile/fontdir.c.old	Sat Jun  8 23:43:20 2002
--- xc/lib/font/fontfile/fontdir.c	Sat Jun  8 23:39:35 2002
***************
*** 728,734 ****
       * Parse out scalable fields from XLFD names - a scalable name
       * just gets inserted, a scaled name has more things to do.
       */
!     if (isscale)
      {
        /* If the fontname says it is scalable, make sure that the
         * renderer supports OpenScalable and GetInfoScalable.
--- 728,734 ----
       * Parse out scalable fields from XLFD names - a scalable name
       * just gets inserted, a scaled name has more things to do.
       */
!     if (isscale || !vals.values_supplied & SIZE_SPECIFY_MASK)
      {
        /* If the fontname says it is scalable, make sure that the
         * renderer supports OpenScalable and GetInfoScalable.

Reply via email to