Author: jeremias
Date: Mon Dec 3 02:16:27 2007
New Revision: 600467
URL: http://svn.apache.org/viewvc?rev=600467&view=rev
Log:
Log RuntimeExceptions during rendering so that they are at least visible
somewhere if someone doesn't set an ErrorListener on the XSLT processor (this
could lead to exceptions being swallowed). This is a temporary measure until we
have time to improve the exception handling in FOP.
The original problem that led to this change was: "The number of this PDFNumber
must not be empty" while producing a PDF/A with customized filter entries in
the PDF configuration. The exception was a follow-up exception after a
PDFConformanceException that was swallowed by a default ErrorListener.
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/area/RenderPagesModel.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFObject.java
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/area/RenderPagesModel.java
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/area/RenderPagesModel.java?rev=600467&r1=600466&r2=600467&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/area/RenderPagesModel.java
(original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/area/RenderPagesModel.java
Mon Dec 3 02:16:27 2007
@@ -22,13 +22,11 @@
// Java
import java.io.IOException;
import java.io.OutputStream;
-import java.util.List;
import java.util.Iterator;
+import java.util.List;
-// XML
import org.xml.sax.SAXException;
-// FOP
import org.apache.fop.apps.FOPException;
import org.apache.fop.apps.FOUserAgent;
import org.apache.fop.fonts.FontInfo;
@@ -119,6 +117,8 @@
try {
renderer.renderPage(page);
} catch (RuntimeException re) {
+ String err = "Error while rendering page " +
page.getPageNumberString();
+ log.error(err, re);
throw re;
} catch (Exception e) {
//TODO use error handler to handle this FOP or IO Exception or
propagate exception
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFObject.java
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFObject.java?rev=600467&r1=600466&r2=600467&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFObject.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFObject.java Mon Dec 3
02:16:27 2007
@@ -83,7 +83,9 @@
*/
public void setObjectNumber(int objnum) {
this.objnum = objnum;
- log.trace("Assigning " + this + " object number " + objnum);
+ if (log.isTraceEnabled()) {
+ log.trace("Assigning " + this + " object number " + objnum);
+ }
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
