Author: spepping
Date: Wed Aug 26 20:00:24 2009
New Revision: 808166

URL: http://svn.apache.org/viewvc?rev=808166&view=rev
Log:
Fixed Checkstyle warnings and replaced a java 1.5 class

Modified:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java
    
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java
    
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java

Modified: 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java
URL: 
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java?rev=808166&r1=808165&r2=808166&view=diff
==============================================================================
--- 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java 
(original)
+++ 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java 
Wed Aug 26 20:00:24 2009
@@ -47,14 +47,14 @@
  */
 public class PatternParser extends DefaultHandler implements PatternConsumer {
 
-    XMLReader parser;
-    int currElement;
-    PatternConsumer consumer;
-    StringBuffer token;
-    ArrayList exception;
-    char hyphenChar;
-    String errMsg;
-    boolean hasClasses = false;
+    private XMLReader parser;
+    private int currElement;
+    private PatternConsumer consumer;
+    private StringBuffer token;
+    private ArrayList exception;
+    private char hyphenChar;
+    private String errMsg;
+    private boolean hasClasses = false;
 
     static final int ELEM_CLASSES = 1;
     static final int ELEM_EXCEPTIONS = 2;

Modified: 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java
URL: 
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java?rev=808166&r1=808165&r2=808166&view=diff
==============================================================================
--- 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java
 (original)
+++ 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java
 Wed Aug 26 20:00:24 2009
@@ -42,19 +42,21 @@
     }
 
     /**
-     * {...@inheritdoc}
+     * Compile all xml files in sourceDir, and write output hyp files in 
targetDir
+     * @param sourceDir Directory with pattern xml files
+     * @param targetDir Directory to which compiled pattern hyp files should 
be written
      */
     public void serializeDir(File sourceDir, File targetDir) {
         final String extension = ".xml";
         String[] sourceFiles = sourceDir.list(new FilenameFilter() {
             public boolean accept(File dir, String name) {
-                return(name.endsWith(extension));
+                return name.endsWith(extension);
             }
         });
         for (int j = 0; j < sourceFiles.length; j++) {
             File infile = new File(sourceDir, sourceFiles[j]);
-            String outfilename =
-                sourceFiles[j].substring(0, sourceFiles[j].length() - 
extension.length()) + ".hyp";
+            String outfilename = sourceFiles[j].substring(0, 
sourceFiles[j].length()
+                                                          - 
extension.length()) + ".hyp";
             File outfile = new File(targetDir, outfilename);
             serializeFile(infile, outfile);
         }
@@ -124,7 +126,11 @@
     }    // end rebuild
 
 
-    public static void main (String args[]) {
+    /**
+     * Entry point for ant java task
+     * @param args sourceDir, targetDir
+     */
+    public static void main (String[] args) {
         SerializeHyphPattern ser = new SerializeHyphPattern();
         ser.serializeDir(new File(args[0]), new File(args[1]));
     }

Modified: 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java
URL: 
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java?rev=808166&r1=808165&r2=808166&view=diff
==============================================================================
--- 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java 
(original)
+++ 
xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java 
Wed Aug 26 20:00:24 2009
@@ -211,7 +211,7 @@
                 if (!"".equals(fields[SIMPLE_TITLECASE_MAPPING])) {
                     titlecode = 
Integer.parseInt(fields[SIMPLE_TITLECASE_MAPPING], 16);
                 }
-                StringBuilder s = new StringBuilder();
+                StringBuffer s = new StringBuffer();
                 if (hexcode) {
                     s.append("0x" + fields[UNICODE].replaceFirst("^0+", 
"").toLowerCase() + " ");
                 }



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to