Author: gadams
Date: Sat Apr 21 04:45:14 2012
New Revision: 1328581

URL: http://svn.apache.org/viewvc?rev=1328581&view=rev
Log:
Bugzilla #51043: Don't restart layout unless abs(ipd difference)>1 in order to 
prevent rounding issues from triggering false restart.

Modified:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java
    xmlgraphics/fop/trunk/status.xml

Modified: 
xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java
URL: 
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java?rev=1328581&r1=1328580&r2=1328581&view=diff
==============================================================================
--- 
xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java 
(original)
+++ 
xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java 
Sat Apr 21 04:45:14 2012
@@ -420,7 +420,7 @@ public abstract class AbstractBreaker {
                 alg.setConstantLineWidth(flowBPD);
                 int optimalPageCount = alg.findBreakingPoints(effectiveList, 
1, true,
                         BreakingAlgorithm.ALL_BREAKS);
-                if (alg.getIPDdifference() != 0) {
+                if ( Math.abs ( alg.getIPDdifference() ) > 1 ) {
                     addAreas(alg, optimalPageCount, blockList, effectiveList);
                     // *** redo Phase 1 ***
                     log.trace("IPD changes after page " + optimalPageCount);

Modified: xmlgraphics/fop/trunk/status.xml
URL: 
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/status.xml?rev=1328581&r1=1328580&r2=1328581&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/status.xml (original)
+++ xmlgraphics/fop/trunk/status.xml Sat Apr 21 04:45:14 2012
@@ -62,6 +62,9 @@
       documents. Example: the fix of marks layering will be such a case when 
it's done.
     -->
     <release version="FOP Trunk" date="TBD">
+      <action context="Code" dev="GA" type="fix" fixes-bug="51043" 
due-to="Pascal Sancho">
+        Don't restart layout unless abs(ipd difference) > 1 in order to 
prevent rounding issues from triggering false restart.
+      </action>
       <action context="Fonts" dev="GA" type="update">
         Removing experimental feature that violates XSL-FO and Unicode 
semantics by misinterpreting Basic Latin code points. Users must use private 
use codepoints to access font specific
         character mappings that have no assigned Unicode code point. See bug 
50492.



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to