Hi Glenn,
On 31/03/2016 16:20, Glenn Adams wrote:
On Thu, Mar 31, 2016 at 1:59 AM, Chris Bowditch
<[email protected] <mailto:[email protected]>> wrote:
I can revert the findbugs part of my changes if that's what the
team wants. Seems Simon wants that also, but I prefer my approach,
since I don't have to drop to the command line and start typing
commands to run Findbugs. With my approach I can run it from the
IDE, and if I have to drop to the command line to run it then I
will likely forget. I'm not sure why Simon is so opposed to my
change, he just says he doesn't like it (despite the fact he
doesn't even use Maven), but if you don't like it too then I will
revert
When you run from IDE, can't you specify explicit goals? Or are you
limited to specifying a list of profiles to apply?
I'm still going to want access to CI to remove the explicit call
to the checkstyle target though. Since my changes its currently
being called twice.
It looks like I may need to ask INFRA to add the access, since I don't
see any way to do it myself.
I found the command to run on minotaur, but got an access denied error.
The instructions say you need to be a PMC chair to run the script;
https://wiki.apache.org/general/Jenkins#How_do_I_get_an_account
In any case, it looks like the problem with the current build failure
is that the exclusions file is not being found. I'm working on the pom
and config now, so give me until the end of the day to see if I can
arrive at a solution.
The exclusions file isn't found because the plugin configuration has
been moved under a profile. Therefore maven is falling back to a default
findbugs configuration. Specifying the profile will resolve this
Chris
On 31/03/2016 08:18, Glenn Adams wrote:
I wonder if it is actually worth creating a phase for findbugs
which invocation still requires one to specify something like
-P runFindbugs. It is just as easy to add a goal
findbugs:check on the command line, isn't it? That's what I've
been using. For the CI configuration, I had used:
mvn clean install checkstyle:checkstyle findbugs:findbugs -B
-U -e -fae -V
On Thu, Mar 31, 2016 at 12:47 AM, Chris Bowditch
<[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>> wrote:
Hi Glenn,
As mentioned in another thread. I can't quite complete the
changes
until I'm given access to CI by being added to the group
hudson-jobadmin. Also, I've only done fop-core so far.
Once I've
got it working and the team are happy I will propagate my
changes
to the other modules.
Thanks,
Chris
On 30/03/2016 16:38, Glenn Adams wrote:
Thanks for fixing. I haven't had a chance to work on
the site
phase, but will do so ASAP.
On Wed, Mar 30, 2016 at 1:56 AM, Chris Bowditch
<[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>> wrote:
The site phase currently appears to be broken.
Rather than
investigate that, I moved findBugs into a profile.
Which
should
suit the requirements of some people wanting
findBugs run
as part
of install and others not wanting it run. Its off
by default.
Chris
On 29/03/2016 16:33, Chris Bowditch wrote:
I prefer to know ASAP whether checkstyle or
findbugs is
broken, and having them in validate/verify
phases supports
this. Moving them to manual scripts (as was
the case
previously) is different to other Maven
projects I've
worked
with and seems to encourage introducing new
issues.
Moving the
phase of Findbugs seems like a fair
compromise, I'll
have a
look into that tomorrow. Alternatively I can
move FindBugs
into its own profile which you have to
explicitly enable.
Thanks,
Chris
On 29/03/2016 16:10, Glenn Adams wrote:
On Tue, Mar 29, 2016 at 1:59 AM, Simon Steiner
<[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>>> wrote:
Hi,
After this change findbugs is always
run for
example:
mvn clean
install -DskipTests
This doesn’t work on java 8 and takes much
longer to run.
I agree with Simon. It is preferable to
explicitly
specify
a findbugs goal when performing compile or
install. The
more standard process is to have findbugs run
automatically when running the site phase.
Thanks
-----Original Message-----
From: [email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>> <mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>>
[mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>> <mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>>]
Sent: 24 March 2016 16:17
To: [email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>>
Subject: svn commit: r1736460 -
/xmlgraphics/fop/trunk/fop-core/pom.xml
Author: cbowditch
Date: Thu Mar 24 16:16:47 2016
New Revision: 1736460
URL:
http://svn.apache.org/viewvc?rev=1736460&view=rev
Log:
Avoid the need to run checkstyle and
findbugs
separately and
integrate them into the build process;
checkstyle runs
in validate
(pre-compile) phase and findbugs runs
in verify
(post-compile) phase
Modified:
xmlgraphics/fop/trunk/fop-core/pom.xml
Modified:
xmlgraphics/fop/trunk/fop-core/pom.xml
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/fop-core/pom.xml?rev=1736460&r1=1736459&r2=1736460&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/fop-core/pom.xml
(original)
+++
xmlgraphics/fop/trunk/fop-core/pom.xml Thu
Mar 24
16:16:47 2016
@@ -300,6 +300,7 @@
</plugin>
<!-- code analysis - checkstyle -->
<plugin>
+
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>${project.baseUri}src/tools/resources/checkstyle/checkstyle.xml</configLocation>
@@ -311,6 +312,15 @@
<suppressionsLocation>${project.baseUri}src/tools/resources/checkstyle/suppressions.xml</suppressionsLocation>
<violationSeverity>warning</violationSeverity>
</configuration>
+ <executions>
+ <execution>
+ <id>validate</id>
+ <phase>validate</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
</plugin>
<!-- code analysis - findbugs -->
<plugin>
@@ -322,6 +332,15 @@
<effort>Max</effort>
<threshold>Low</threshold>
</configuration>
+ <executions>
+ <execution>
+ <id>verify</id>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
</plugin>
</plugins>
<resources>
---------------------------------------------------------------------
To unsubscribe, e-mail:
[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>>
For additional commands, e-mail:
[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>>
