Hi Christian, I agree that it is good to get patches in, the problem has been that in many cases these patches are altering messy code (eg. LineArea.java) and its a case of fix one problem and create others or it is not clear if it works properly. This problem is best solved by better design and testing (and more resources).
I will commit the ones you propose and hope for the best. Regards, Keiron. On 2002.01.10 18:54 Christian Geisert wrote: > Ok, > > while browsing the archives I found the following uncomitted patches, > and as it is quite frustrating if your patch gets not noticed (and you > worked hard for it..) we should try to commit all (if possible). > > * improved font-encoding by Peter S. Housel > (see http://marc.theaimsgroup.com/?l=fop-dev&m=100559770232644&w=2) > To build with this patch you need optional.jar from ant 1.3 > (download > >http://jakarta.apache.org/builds/jakarta-ant/release/v1.3/bin/jakarta-ant-1.3-optional.jar > > and copy it to lib/optional.jar) and add it to build.bat (build.sh has it > two > times ;-) > I noticed the same problems as Rainer Garus > (see http://marc.theaimsgroup.com/?l=fop-dev&m=100790930100949&w=2) > Peter, what do you think? > > * improved line-breaking-algorithm for japanese by Satoshi Ishigami > (see http://marc.theaimsgroup.com/?l=fop-dev&m=100311137529637&w=2) > Looks good :-) and does not seem to break anything. > My proposal: commit > > * bug fix for hypenation by Enrico Schnepel > (see http://marc.theaimsgroup.com/?l=fop-dev&m=100162872404800&w=2) > Fixes a infinite loop and does not seem to break anything. > My proposal: commit > > * new "swing-handler" from Alistair Hopkins > (see http://marc.theaimsgroup.com/?l=fop-dev&m=100591163523860&w=2) > Seems to be "work in progress", probably something for the main branch > > * Patch that keeps list-item-label and list-item-body together > by Don Wellington > (see http://marc.theaimsgroup.com/?l=fop-dev&m=99842833609271&w=2) > Strange patch format, Don can you resubmit as unified patch? > > * AWTRenderer patch by Ralph LaChance: fixes "small border" problem > (see http://marc.theaimsgroup.com/?l=fop-dev&m=99719917329956&w=2) > I've done a real patch and attached it to this mail. > > Christian. > Index: src/org/apache/fop/render/awt/AWTRenderer.java > =================================================================== > RCS file: > /home/cvspublic/xml-fop/src/org/apache/fop/render/awt/AWTRenderer.java,v > retrieving revision 1.38 > diff -u -r1.38 AWTRenderer.java > --- src/org/apache/fop/render/awt/AWTRenderer.java 26 Sep 2001 > 12:00:42 -0000 1.38 > +++ src/org/apache/fop/render/awt/AWTRenderer.java 10 Jan 2002 > 16:44:33 -0000 > @@ -271,10 +271,14 @@ > int starty = pageHeight - ((y + 500) / 1000); > int endx = (x + w + 500) / 1000; > int endy = pageHeight - ((y + h + 500) / 1000); > - if (drawAsOutline) > + if (drawAsOutline) { > graphics.drawRect(startx, starty, endx - startx, endy - > starty); > - else > + } else { > + //don't round down to zero > + if (w != 0 && endx == startx) endx++; > + if (h != 0 && endy == starty) endy++; > graphics.fillRect(startx, starty, endx - startx, endy - > starty); > + } > } > > protected void addFilledRect(int x, int y, int w, int h, > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, email: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
