Team, Two changes I would like to make to the 1.0dev branch:
1.) Rename the org.apache.fop.area.inline.Word class to org.apache.fop.area.inline.Text, and rename the renderWord() method in the Renderer subclasses to renderText(). Reason: It's a lot clearer, given the data these objects hold and what this particular renderer method is actually doing. The objects that Word contains are basically strings of words sharing common formatting characteristics, and hence much more closely map to "Text" in meaning than "Word". Like the other inline areas in this package, its name used to have "Area" as a suffix in maintenance (i.e., WordArea), which didn't signify a single word, but removing the "-Area" ended up giving the class a somewhat misleading name in 1.0. For example, a run of our sample.fo is yielding these Word objects being processed by the renderWord() method of the PDFRenderer: Word = " Extensible Markup Language (XML) 1.0" Word = " The Extensible Markup Language (XML) is a subset of SGML that is completely" Word = "described in this document. Its goal is to" Word = " enable generic SGML to be served," Word = "received, and processed on the Web in the way that is now possible with HTML. XML" Word = "has been designed for ease of implementation and for interoperability with both" Word = "SGML and HTML." Word = " The Extensible Markup Language (XML) is a subset of SGML that is completely" Word = "described in this document. Its goal is to" Word = " enable generic SGML to be served," Word = "received, and processed on the Web in the way that is now possible with HTML. XML" Word = "has been designed for ease of implementation and for interoperability with both" Word = "SGML and HTML." This is confusing--Text/renderText() is better for these objects. Here is my +1. 2.) Move the org.apache.fop.pdf package to a new org.apache.fop.render.pdf.document package. This package is pdf-specific, and I think is best placed under the render.pdf directory rather than at the root. This package currently holds the PDF document representation used in PDF rendering, and also has several classes used by the PDF Transcoder. This is more of a general goal--i.e., if we have new PS- or PCL-specific packages needed in rendering/transcodering in the future they will also go under the respective renderer directory instead of at the root. Currently org.apache.fop.pdf is our only problem directory though (We haven't had a need for special packages for PCL/PS; and I already moved the AWT-specific viewer package from the root to render.AWTRenderer.viewer a couple of months back.) Here is my +1. Thoughts? (Committer) votes? Sorry for the long post. Thanks, Glen __________________________________ Do you Yahoo!? Exclusive Video Premiere - Britney Spears http://launch.yahoo.com/promos/britneyspears/
