DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=28237>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28237 [PATCH] Use the commons logging LogFactory also in Fop.java ------- Additional Comments From [EMAIL PROTECTED] 2004-04-09 03:18 ------- Thanks for the explanation, Simon. I understand a lot more now and have committed most of your patch, but with a few changes. Please take a look at the new version and let me know what you think. Changes I didn't commit were a couple of minor issues I had some question on--namely, your wrapping and creating of new logs based on -d and -q options in CLO.parseOptions(): (a) why place within isDebugEnabled() and isWarnEnabled() conditionals, why does this matter? (b) one conditional is !isDebugEnabled() with a negative but the other is the positive isWarnEnabled()--was this a bug? (c) Finally, did you actually mean isErrorEnabled() for the latter? BTW, please always use { } for the conditionals instead of single-lines [1]: if (a > b) { c = d; } http://xml.apache.org/fop/dev/conventions.html Thanks again, Glen
