DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29124>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29124

New line breaking algorithm





------- Additional Comments From [EMAIL PROTECTED]  2004-08-19 19:30 -------
Luca,

This is a good piece of work again. Nevertheless, I did succeed in
breaking the code. See the following test fo files.

Nested inline and other LMs: The output contains errors, see the
comments in the text. The errors occur when hyphenation is set to
true.

Justification: This is a test fo you submitted earlier. According to
the text in the file the second block should be hyphenated; it is
not. Should it still be hyphenated, or can this not be enforced with
the Knuth algorithm and text-align="start"?

No breakpoints: An exception is thrown, at
LineLayoutManager.getNextBreakPoss(LineLayoutManager.java:495). It
occurs because breakpoints has size 0; the third call to
findBreakingPoints also returned 0. This should not be possible; the
algorithm should always return a breakpoint.

A few small remarks:

Can you move the following log messages to trace log level:
[DEBUG] AbstractLayoutManager - - Word to hyphenate: We

In TextLM, returning null for a forced LF is not an idea that I like,
because it overloads the null return value. Cannot you return an
special Knuth element for LF? Alternatively, you could return null and
process the paragraph. The second paragraph would then be produced and
processed later.

InlineStackingLM.getNextKnuthElements: 'if (lc.startsNewArea())' no
longer used?

Regards, Simon

Reply via email to