DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=31206>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31206 [PATCH] Improvements over the new line breaking algorithm ------- Additional Comments From [EMAIL PROTECTED] 2004-11-06 14:24 ------- Luca, Leaders with content: in the test file leaders.fo I get PDF errors in the SVG parts. I have not checked the calculations of the vertical alignment. The provided test fo files, and some test files I created myself, behave well under the new code. I trust the code is OK. As Finn pointed out, vertical-align is a shorthand property in XSL. The values top, bottom, middle and baseline map to the values before-edge, after-edge, middle and baseline of the property alignment-baseline, with the properties alignment-adjust, baseline-shift and dominant-baseline being at their default values. Therefore I think if the current property vertical-align is renamed to alignment-baseline, the code will keep working fine, and the way is free to implement vertical-align as a shorthand property. InlineLM is now a class (created by Finn on Oct. 19). The hierarchy is: InlineStackingLM - InlineLM - LineLM The class InlineLM is at the position in the hierarchy where I think InlineLM interface should be. Therefore I think InlineLM class can well be merged with the proposed InlineLM interface. I think the code in this patch is OK for committing to CVS. The items noted above can be addressed over time. However, the patch as it is cannot be applied to the current version of CVS HEAD, due to the newly created InlineLM class and extensive changes in property retrieval. If you submit a patch of the same code against the current CVS HEAD, I will commit it. Or you can keep it until you have write access to CVS yourself. Regards, Simon
