Glen, this was quite interesting. Right after your change here, my local changes started to fail. Obviously, my changes for changing BPD between pages was the first use case for getTopLevelLM() to fetch the PSLM. But you are likely to remove the LayoutManager interface from PSLM I took a different route and made the PageViewportProvider available differently. I hope that was acceptable and still as clean as possible. I was also thinking about promoting the PageViewportProvider in PSLM to a full class. But I left it out for now.
On 14.06.2005 04:54:09 gmazza wrote: > gmazza 2005/06/13 19:54:09 > > Modified: src/java/org/apache/fop/layoutmgr > PageSequenceLayoutManager.java > Log: > Switched to null for PageBreaker.getTopLevelLM(). > Not being used by the page-breaking process. > > Revision Changes Path > 1.67 +2 -2 > xml-fop/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java > > Index: PageSequenceLayoutManager.java > =================================================================== > RCS file: > /home/cvs/xml-fop/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java,v > retrieving revision 1.66 > retrieving revision 1.67 > diff -u -r1.66 -r1.67 > --- PageSequenceLayoutManager.java 9 Jun 2005 02:39:55 -0000 1.66 > +++ PageSequenceLayoutManager.java 14 Jun 2005 02:54:09 -0000 1.67 > @@ -157,7 +157,7 @@ > } > > protected LayoutManager getTopLevelLM() { > - return pslm; > + return null; // unneeded for PSLM > } > > protected LinkedList getNextKnuthElements(LayoutContext context, > int alignment) { Jeremias Maerki