I see. So, do you know how to create a patch? Just run "svn diff >mydiff.txt" and send us the file. That way I don't have to recreate all your changes. Thanks in advance!
On 27.07.2005 10:44:54 Bielik, Robert wrote: > No, there were a couple of other changes. They were as follows: > > 1) In PageSequenceLayoutManager.java inner class PageBreaker, all 'log.' were > changed to 'pslm.log.' so that the log instance in PageSeq...Manager.java is > called. > > 2) In org.apache.fop.render.bitmap.TIFFRenderer the getLogger() call in the > inner class LazyPageImagesIterator method next() was out-commented. I'm not > sure how to get to TIFFRenderer.getLogger() from here. > > 3) In org.apache.fop.render.java2d.Java2DRenderer all calls to Color > constants were changed to lower case. Here it was Color.WHITE -> Color.white. > > 4) In org.apache.fop.render.pdf.PDFXMLHandler it was Color.BLACK -> > Color.black . > > If memory serves me right, that was it :) > > /R > > > > -----Original Message----- > > From: Jeremias Maerki [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, July 27, 2005 10:34 AM > > To: fop-dev@xmlgraphics.apache.org > > Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? > > > > > > Thanks for taking the time. Are you sure that these are all > > the changes > > that were necessary? When I change what you indicated here, I > > still get > > a few other errors. If you made more than just these > > modifications would > > you please send us a patch so I can put the changes into the > > repository? > > > > The thing that surprises me is the timestamp stuff but that > > should be no > > problem since it is only informational. The fix in > > Java2DRenderer looks > > fine. I'll verify that it still works when I add the changes > > to the repo. > > > > On 27.07.2005 10:09:25 Bielik, Robert wrote: > > > Ok, I've now managed to get everything to compile alright. > > It wasn't really any > > > large problems. However, there is one in > > Java2DRenderer.java regarding ColorModel: > > > > > > Original code (1001): > > > > > > ColorModel cm = new ComponentColorModel(ColorSpace. > > > > > getInstance(ColorSpace.CS_LINEAR_RGB), false, false, > > > ColorModel.OPAQUE, > > DataBuffer.TYPE_BYTE); > > > > > > which made javac complain about wrong number of arguments. > > It seems that an int[] denoting the bitdepth of each color > > component was lacking, so I changed it to: > > > > > > ColorModel cm = new > > ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), > > > new int[] {8, 8, 8}, > > > false, false, > > > ColorModel.OPAQUE, > > DataBuffer.TYPE_BYTE); > > > > > > I guess thats OK? (since there seems to be no alpha component) > > > > > > However, then ant crashes at build.xml (480) complaining > > about wrong timestamp format: > > > "yyyy-MM-dd'T'HH:mm:ssZ" > > > > > > so I changed that to the other jar creation tstamp formats: > > > "yyyyMMdd-HHmmss-z" > > > > > > Then it all goes through. However, if it'll work, that's > > another matter... ;) > > > > > > /R > > > > > > > -----Original Message----- > > > > From: Jeremias Maerki [mailto:[EMAIL PROTECTED] > > > > Sent: Wednesday, July 27, 2005 9:07 AM > > > > To: fop-dev@xmlgraphics.apache.org > > > > Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? > > > > > > > > > > > > > > > > On 27.07.2005 08:54:27 Bielik, Robert wrote: > > > > > Phew... OK, I'll try. Though I have very limited insight > > > > into FOP to know what my > > > > > changes would incur, and unfortunately _very_ limited time > > > > so I don't want you to > > > > > count on me... ;) > > > > > > > > If you have very limited time then it's probably too soon for > > > > you to try > > > > out FOP Trunk. It's still work in progress and we're only > > planning the > > > > first preview (!) release. It's not like the whole thing is > > > > already fit > > > > for production work. It's a good time for interested > > people to try out > > > > the code and provide some feedback (or even better, fixes). > > > > > > > > > Btw, when you develop FOP, what environment are you using ? > > > > I'm thinking of > > > > > cramming it into Eclipse which is sailing up to be my > > > > number 1 choice of IDE :) > > > > > > > > You're free to choose. I personally use Eclipse as do a few > > > > others. Just > > > > make sure you run "ant codegen" to create the > > build/gensrc directory > > > > which you have to add to the source path. > > > > > > > > http://wiki.apache.org/xmlgraphics-fop/FOPIDESetupGuide > > > > > > > > > Regards > > > > > /R > > > > > > > > > > > -----Original Message----- > > > > > > From: Jeremias Maerki [mailto:[EMAIL PROTECTED] > > > > > > Sent: Wednesday, July 27, 2005 8:48 AM > > > > > > To: fop-dev@xmlgraphics.apache.org > > > > > > Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? > > > > > > > > > > > > > > > > > > Until we decide otherwise, FOP is still targeted at JDK > > > > 1.3 but you're > > > > > > right it currently doesn't compile. Nobody took the time, > > > > yet, to make > > > > > > it compile under 1.3. It's on my list of things but there > > > > are so many > > > > > > little things still to do. If you could try to fix it and > > > > send a patch > > > > > > that would be absolutely awesome! Do you want to try? > > > > > > > > > > > > On 27.07.2005 08:14:14 Bielik, Robert wrote: > > > > > > > The question seemed to fit in this list rather than > > fop-users: > > > > > > > > > > > > > > I've checked out the fop trunk and tried to build it with > > > > > > JDK 1.3, however > > > > > > > that doesn't seem to work (getting a number of compile > > > > > > errors on among other > > > > > > > things, java.awt.Color) > > > > > > > > > > > > > > Is the trunk known to require JDK1.4 or higher, if not, > > > > > > what do I need to > > > > > > > think about ? > > > > > > > > > > > > > > The reason I need JDK 1.3 is that I'm trying to fit fop > > > > > > into an application > > > > > > > where JRE1.3 is used, AND I need it to be able to render > > > > > > the (embedded) SVG in the > > > > > > > XSL-FO which is what doesn't work for me in fop 0.20.5. > > > > > > > > > > > > > > TIA > > > > > > > /Rob > > > > > > > > > > > > > > > > > > > > > > > > Jeremias Maerki > > > > > > > > > > > > > > > > > > > > > > > > > > > > Jeremias Maerki > > > > > > > > > > > > > > > > Jeremias Maerki > > > > Jeremias Maerki
