DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36082>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36082 ------- Additional Comments From [EMAIL PROTECTED] 2005-08-10 13:48 ------- The FOUserAgent.openStream() method is currently empty that's why I removed the call and put the comment in. However, I since worked on the GIF crashing issue. To make it work I had to change the interfaces. Instead of an InputStream the ImageFactory.openStream function (renamed to openURLConnection()) returns a URLConnection. This is then stored in addition to the InputStream in the FopImage.ImageInfo structure so GifImage can use it to get the properURLImageSource. However, all this is done without using FOUserAgent. To move this logic into FOUserAgent we would need a function in FOUserAgent like: URL getURL(String url) or may be better named URL resolveURL(String url) This would take the string argument url and combine it with the baseURL to form a proper absolute URL. This would be the main function someone would overwrite in a FOUserAgent subclass to provide custom URL resolution and to implement custom URL schemes. We could then add helper functions to FOUserAgent like: URLConnection openConnection(String url) which would first resolve the url and then do an openConnection on it and similar: InputStream openStream(String url) which would call openConnection(url) first and then return its InputStream. These helpers may save a few lines of code in a few places in fop but are not really core. Comments please ? Am I on the right track? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
