Both are bugs. Thanks for finding them. I'm currently working on
testing for them and fixing them.

On 19.10.2005 22:04:47 Simon Pepping wrote:
> Jeremias,
> 
> Two questions, about SpaceResolver.resolve():
> 
> 1. performSpaceResolutionRules2to3(firstPart, firstPartLengths);
>    Should the resolution not be applied to the reverse of firstPart
>    and firstPartLengths, because you may be locating the last space
>    specifier in the original order?
> 
> 2. if (isFirst || isLast) {
>        performSpaceResolutionRule1(secondPart, secondPartLengths);
>    }
>    If isLast, then the edge of the reference area is at the
>    end. Should then the resolution not be applied to the reverse
>    of secondPart and secondPartLengths?
> 
> Regards, Simon
> 
> On Thu, Oct 13, 2005 at 08:23:50PM +0200, Jeremias Maerki wrote:
> > I finally uploaded my space resolution work so far. It's still not
> > finished. When you go through the details you always find more stuff to
> > look into and to fix. But most of it works now and is available for
> > review while I work on the remaining issues. I assume there is room for
> > optimization here and there. So don't hesitate to jump in and help. The
> > enabled test cases all pass.
> 
> -- 
> Simon Pepping
> home page: http://www.leverkruid.nl



Jeremias Maerki

Reply via email to