DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=37253>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=37253 ------- Additional Comments From [EMAIL PROTECTED] 2005-11-09 13:29 ------- (In reply to comment #2) > I've had a look at this patch. The output looks quite good on most files I > checked so far. The border and background painting stuff is very cool. However, > you might want to look at examples/fo/basic/readme.fo where the page numbers are > not quite in the right place. Here footer string size ("This is not the latest Fop documentation, but just an fo example. FOP - p. ") is too long, so page number is in the wrong place. Delete one character from this string and you'll get correct output. >And examples/fo/basic/list.fo has a problem on the last page. Fixed. > Anyway, the above is not a big problem right now. What I'd like you to do is > revisit the patch and change the following: > - Convert all tab characters to spaces. We don't allow tab characters in our > codebase. It would be best if you installed Checkstyle 3.5 and checked your code > against the rules found in the FOP root directory. > - I'd like to see a little more javadocs (to fix the Checkstyle warnings I get). Fixed. > We're trying to gradually fix all the warnings as we go and I'd not want to > introduce too many new ones. > Would you please post a revised patch fixing the two issues above? Thanks! > Another thing that should be looked (not mandatory IMO) at are the warnings due > to the getValue() calls without a PercentBaseContext. I don't say what you did > was wrong and the warning shouldn't be issued. However, I think your code > doesn't handle percentages right now. On the other side, I'm not sure how to > properly handle this case in TXTHandler. Me too. Sorry, but I have no time to resolve it now. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
