DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38618>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38618


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From [EMAIL PROTECTED]  2006-02-11 21:34 -------
(In reply to comment #0)
> Dear FOP developers,
> 
> I am really happy with the new FOP. It finally renders my documents the way I
> like it.

I'm happy to hear that.

> I would love to see the red spots on the compliance chart disappear, and I
> decided to help out.

That's the spirit!!! Are there more guys like you where you come from? :-)

> This patch 
> - removes functionality that was duplicated (in RGBColorFunction and
> ColorTypeProperty)
> 
> - Adds better error handling to ColorTypeProperty
> 
> - Adds support for the system-color() function
> 
> I hope I follwed all the necessary steps.

Good stuff. I modified your patch just a little to fix some Checkstyle issues
and to handle the "FIXME" you had in the patch. I also added your FO file as a
test case to the repo.

New files normally require that you have an CLA [1] on file with the ASF, but
since the addition was such a trivial class I consider it subject to chapter 5
in the ALv2 like the rest of the patch. I hope that was only the first of your
patches. If you start doing bigger changes I would like you to submit an CLA [1]
to the ASF. If you have any questions about that, please ask.

[1] http://www.apache.org/licenses/#clas

So, patch applied. Thanks a lot!
http://svn.apache.org/viewcvs?rev=377045&view=rev

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to