DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=39777>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39777 ------- Additional Comments From [EMAIL PROTECTED] 2006-06-12 12:45 ------- (In reply to comment #0) > This patch isn't really meant to be applied... Rather to be reviewed by > interested parties to check if I'm not wrong. Changelog: > * javadocs for the Knuth line- and page-breaking algorithms. Some items are > marked with double question marks because I haven't found out yet what is > their > purpose. I will probably find eventually, but if anybody has immediate hints > they will be welcome. KnuthBlockBox: bpdim seems to be used in concert with the proprietary display-align="fill" value Luca implemented. See AbstractBreaker.optimizeLineLength(). If I understand it right it is somehow used to make sure all the pages have more or less the same amount of content (in bpd). pos and bAux are defined in ListElement/KnuthElement. BreakingAlgorithm: alignment: EN_BEFORE is not used. EN_START is used instead, since the class is used in both ipd and bpd. EN_BEFORE is mapped into EN_START. Actually, alignment uses a slightly different set of value than the FO properties, so reusing the integer constants may not be the best thing, but we're not under Java 5, yet, where we could use enums. bFirst is used for the text-indent property so only the first paragraph of a block is indented. See block_text-indent.xml. partOverflowRecovery is used in page breaking to defer an element which would overflow the available BPD to the next page if it's the only element in a part (=line or page). > * some methods have been marked deprecated because AFAICT they are not called > anywhere. If this is agreed I'll remove them in my next patch +1 > * bugfix? In the last for loop of the method > layoutmgr.PageBreakingAlgorithm.noBreakBetween I think the exit condition > should > be a strict comparison ('<' instead of '<='). Confirmation? not sure. :-( > * the javadoc comments for some methods have been removed because they will > inherit them from their super-class I think Checkstyle will bark about that. If you do Ctrl-J in Eclipse, you get an automatic @see entry which satisfies Checkstyle. @inheritDoc does not work in every Java version. > * some checkstyle fixes HTH -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
