DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42278>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42278





------- Additional Comments From [EMAIL PROTECTED]  2007-05-14 13:14 -------
Thanks for yet another patch, Adrian. Sorry it takes so long to process them.

I've got three comments on this one:
1. The HyphenationTreeResolver seems to me like a foreign body in the
FOPResolver class. IMO, it's abuses that class as carrier. Can't you hold that
reference in a different place for your PostScript stuff and keep the reference
in the FopFactory?
2. You're naming the class with the resolution code from FopFactory
"FOPResolver". Now, with the existing "FOURIResolver" in the same package, I get
the impression that there will be questions like: What is what? What's the
difference between FOURIResolver and FOPResolver? What do you think about
merging FOPResolver into FOURIResolver? I think this would be a safe thing to 
do.
3. I'm very much against introducing singletons for FopResolver,
ElementMappingRegistry and ColorSpaceCache. Getting rid of all the singletons
was one of my design goals for the new FOP API. The FopFactory should be reused
whenever possible by the user (you could have a singleton for FopFactory in your
app, though), but I want to create FopFactories which are completely separate
from each other. The ColorSpaceCache is probably a border case since it doesn't
make much sense to keep multiple instance of this class, but I wouldn't want
singletons for the other two because of unwanted side-effects (configuring one
FOP environment (i.e. FopFactory) shouldn't modify the other).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to