DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=42809>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42809 Summary: [PATCH] Refactoring of PageSequenceLayoutManager and provide common FObj id property use Product: Fop Version: 1.0dev Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: [email protected] ReportedBy: [EMAIL PROTECTED] Whilst investigating another bug and reading through and trying to understand the code I found that the following structural changes to the code made sense :- * The AreaTreeHandler had several member variables specifically with the remit of tracking the use of Ids in PageViewPorts so this was factored out into a new IDTracker class. * The FlowLayoutManager member variable in PageSequenceLayoutManager was only referenced within PageBreaker so this member variable was moved out to PageBreaker. * The PageBreaker inner class of PageSequenceLayoutManager was getting rather large (larger than its holding class) and had minimal dependencies so I felt it was deserved moving out to the top level. * The PageProvider inner class of PageSequenceLayoutManager had very little dependencies on its holding class and was has been moved to the top level. * I found many instances of an id property and associated getId() accessor method in FObj descendants so it made sense to have this in the base FObj class and remove all other instances. Also added hasId() convenience method. * BasicLinkLayoutManager makes use of new BasicLink has(Internal|External)Destination() convenience methods. * Removed List blockLists argument from the AbstractBreaker/PageBreaker getNextBlockList() protected method as its only usage is the AbstractBreaker blockLists member variable. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
