https://issues.apache.org/bugzilla/show_bug.cgi?id=45971
Vincent Hennebert <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Summary|Fop CLI Errors (Patch to |[PATCH] Fop CLI Errors
|Correct Included) |
--- Comment #1 from Vincent Hennebert <[EMAIL PROTECTED]> 2008-10-13 03:48:58
PST ---
Hi Tom,
Good thing you created a bug report for this, it was being forgotten. Patch
applied in revision 704008
(http://svn.apache.org/viewvc?view=rev&revision=704008). The following
modifications were made:
- minor style fixes (illegal tab characters)
- System.exit is called at only two places: with a return value of 1 when an
unknown argument is given; with a return value of 0 in all other cases. The
rationale is that it's not erroneous to simply run fop without argument, or
with -v or -h.
- the help message is accordingly sent to either stderr or stdout
The semantic of the boolean return value has been changed: false now indicates
that processing should stop normally, not because of an error (there are
exceptions for that).
Ideally this whole part of the code should be re-worked to make use of a common
command-line parsing library (Apache Commons CLI), but this patch is a
reasonable trade-off.
Please re-open the bug if you're not happy with the modifications made.
Thanks Tom!
Vincent
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
