Hi Georg, Georg Datterl wrote: > Hi Vincent, > >> It appears that bug #46322 is on the way of properly testing this extension, >> with the 'one line of the spanning block at the bottom of the page' problem. >> Either the test will need to be tweaked in order to work around the bug, at >> the risk of not being extensive enough, or it will have to be disabled until >> bug >> #46322 is fixed. More in the next episode... > > If I understand correctly, you worry that a fixing of #46322 will invalidate > this test case? How about changing the test case for #46315 after fixing > #46322?
Yes, that’s a possibility. Why not, after all... > If that's the only problem left with my patch, I'll move on to the next > extension... Yes it’s looking good otherwise. Although we might get back to you about writing a bit of documentation once the fixing of the other bugs makes this extension more widely usable ^^ Thanks, Vincent > Mit freundlichen Grüßen > > Georg Datterl > > ------ Kontakt ------ > > Georg Datterl > > Geneon media solutions gmbh > Gutenstetter Straße 8a > 90449 Nürnberg > > HRB Nürnberg: 17193 > Geschäftsführer: Yong-Harry Steiert > > Tel.: 0911/36 78 88 - 26 > Fax: 0911/36 78 88 - 20 > > www.geneon.de > > Weitere Mitglieder der Willmy MediaGroup: > > IRS Integrated Realization Services GmbH: www.irs-nbg.de > Willmy PrintMedia GmbH: www.willmy.de > Willmy Consult & Content GmbH: www.willmycc.de > -----Ursprüngliche Nachricht----- > Von: bugzi...@apache.org [mailto:bugzi...@apache.org] > Gesendet: Dienstag, 13. Januar 2009 12:34 > An: fop-dev@xmlgraphics.apache.org > Betreff: DO NOT REPLY [Bug 46315] fox:needs-balancing extension > > https://issues.apache.org/bugzilla/show_bug.cgi?id=46315 > > > > > > --- Comment #5 from Vincent Hennebert <vhenneb...@gmail.com> 2009-01-13 > 03:34:11 PST --- (In reply to comment #4) >> (In reply to comment #3) >>> Created an attachment (id=23098) > --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23098) [details] > [details] >>> Second try of patch >>> >>> Please review and comment. >>> >> Hi Georg, >> >> Thanks for the patch. It's almost ready to be committed, but I'd like >> to simplify the test case a bit (remove the inline elements and the >> Arial font specification). Unfortunately that affects line height so >> the whole test needs to be re-worked to give to same results as >> before. I'll probably finish that tomorrow. >> >> Vincent > > > Vincent