Looks good. On 06.03.2009 12:27:15 Vincent Hennebert wrote: > Hi Jeremias, > > Sorry to get back so late on this. > > > Author: jeremias > > Date: Mon Feb 16 08:09:29 2009 > > New Revision: 744851 > > > > URL: http://svn.apache.org/viewvc?rev=744851&view=rev > > Log: > > Now using the "font" filter list entry for font streams. > > Made T1 and TTF streams children of a commons base class. > > Refactored default filter addition a bit. > > I think this could still be further simplified. Is the code âfail-fastâ? > I mean: What happens if, when implementing a new sub-class, a developer > forgets to call super.setupFilterList? Will the code fail quickly at an > obvious place or will you figure it out only after having wasted > a certain amount of time in a debugging session? > > Anyway, please have a look at the attached patch. The idea is not to ask > sub-classes to set up the filter list themselves, but rather to ask them > what is their default filter. Thatâs all they need to know, thatâs the > only thing thatâs specific. Small change in the point of view. In the > present case that may sound negligible or ridiculous or whatever, but > I believe it illustrates the whole object-oriented philosophy. In more > complex cases I think this can make a big difference. > > If youâre ok with the patch Iâll apply it. > > Thanks, > Vincent
Jeremias Maerki
