https://issues.apache.org/bugzilla/show_bug.cgi?id=46980





--- Comment #1 from Andreas L. Delmelle <[email protected]>  2009-04-08 
11:26:28 PST ---

Thanks for the patch! Seems like a good starting point.
Only some very minor details (code-style) I'd change:

"if (namedDestination == true) ..." 

No idea if it's just me, but boolean comparisons almost always seems a bit
silly, as you can just write:
"if (namedDestination) ..."

Consequently, I'd also rename that member to something like 'isInternal' or
'hasInternalDestination', yielding the self-explanatory:
"if (this.isInternal) ..."

For the rest, the small piece of added code in PDFFactory can probably better
be added to getGoToPDFAction(), to be executed in case the parameter 'filename'
is null. (opportunity to avoid code-duplication)

Anyone with further suggestions before I commit this one, including the above
modifications?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to