Hi Andreas,

Again, most of the clean up looks good, only...

> Author: adelmelle
> Date: Sat Jul  4 17:00:05 2009
> New Revision: 791153
> 
> URL: http://svn.apache.org/viewvc?rev=791153&view=rev
> Log:
> Further cleanup/readability improvements
> 
> Modified: 
> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java
> URL: 
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java?rev=791153&r1=791152&r2=791153&view=diff
> ==============================================================================
> --- 
> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java 
> (original)
> +++ 
> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java 
> Sat Jul  4 17:00:05 2009
> @@ -399,7 +429,13 @@
>                  ListElement lastBreakElement = 
> effectiveList.getElement(endElementIndex);
>                  if (lastBreakElement.isPenalty()) {
>                      KnuthPenalty pen = (KnuthPenalty)lastBreakElement;
> -                    lastBreakClass = pen.getBreakClass();
> +                    // TODO Handle keep.within-column differently so that 
> break class is
> +                    // automatically set to the right value
> +                    if (pen.getP() >= KnuthPenalty.INFINITE - 1) {
> +                        lastBreakClass = Constants.EN_COLUMN;
> +                    } else {
> +                        lastBreakClass = pen.getBreakClass();
> +                    }

... Another leak from the keep-within-column patch?


Thanks,
Vincent

Reply via email to