Summary: [PATCH] resolve compilation warnings
           Product: Fop
           Version: 1.1dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general

Created an attachment (id=25838)
 --> (
Patch against revision 982124.

This patch resolves all compilation warnings save for one, described below.
Comments follow:

* some deprecation warnings were eliminated by removing the deprecation; this
was done only in those cases where no alternative mechanism was defined; in
general, a feature should not be deprecated unless a documented and working
alternative exists; in these cases, i left a comment in the code indicating
this; the deprecations removed were on the following:

  - FONode.getContextInfo
  - MinOptMax.{plus,minus}{Min,Max}

* one deprecation remains, and another eliminated through a work around, both
of which derive from the deprecation of drawString(String,...) in the
org.apache.xmlgraphics.java2d.TextHandler interface; in general, a method in an
exported interface should not be deprecated unless an adapter class is exported
as well that implements the interface along with the deprecated method; in the
present case, a class (StrokingTextHandler) was exported that could serve in
this role, and that was used to create a fix for one warning;  however, the
second warning, which is based on use of the PSTextHandler interface could not
be eliminated, since no class was exported that could serve as an adaptor;
consequently, to fix the last remaining warning a patch will have to be made to
the xmlgraphics commons (I will submit such a patch, which, once implemented,
will allow fixing the last warning);

This patch was created relative to revision 982124 of FOP trunk.


Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to