https://issues.apache.org/bugzilla/show_bug.cgi?id=50245
--- Comment #4 from Simon Pepping <spepp...@apache.org> 2010-11-11 10:46:58 EST --- I studied the first changes in the patch in more detail.A couple of remarks: PrintRendererConfigurator: in setupFontInfo: change List fontCollections to List<FontCollection> fontCollections, and similarly for all related statements. RendererConfigurator: configure does not throw a URISyntaxException. IFDocumentHandlerConfigurator: setupFontInfo does not throw a URISyntaxException. FontResourceCache: Typeface tf = (Typeface)fonts.get(key): The cast is not necessary, FontMetrics tf works as well. But see the remark under FontInfo. PSFontUtils: writeFontDict: Change Map fontResources to Map<String, PSResource> fontResources and related statements. reencodeFonts: change Map fonts to Map<String, FontMetrics> fonts and related statements. But see the remark under FontInfo. FontInfo: fonts and usedFonts: The code often assumes that the value is a TypeFace. In InstalledFontCollection, Base14FontCollection and ConfiguredFontCollection it is a FontMetricsMapper, but in all three the type can be changed to Typeface. Therefore change Map<String, FontMetrics> usedFonts and Map<String, FontMetrics> fonts Map<String, Typeface> usedFonts and Map<String, Typeface>. Note: This is possible because Typeface and its subclasses are the only classes directly implementing FontMetrics, so that all FontMetrics objects are also Typeface objects. Simon -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
