https://issues.apache.org/bugzilla/show_bug.cgi?id=51596
--- Comment #3 from Simon Pepping <[email protected]> 2011-08-03 08:03:11 UTC --- Thanks for your explanation. The title suggests that the patch cleans up something; it does not; it implements a redesign. Without knowing much detail about Glyf tables, I was a bit surprised about the method names GlyfFlags.offsetToNextComposedGlyf(int flags) and GlyfFlags.moreComposites(int flags). At first sight it suggests that there is some hidden iterator. After some more thought, I assume that flags contains pointers to data in the table, and that these allow one to calculate the extent of this glyf; if that is so, then offsetToNextComposedGlyf may be better called extentOfComposedGlyf. Otherwise the design seems fine, but I am not able to judge about the correctness of the code. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
