sounds reasonable On Tue, Jan 24, 2012 at 2:52 AM, <bugzi...@apache.org> wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 > > Bug #: 52513 > Summary: [PATCH] Moving FOUserAgent to the constructor of > Renderers > Product: Fop > Version: 1.1dev > Platform: PC > OS/Version: Linux > Status: NEW > Severity: normal > Priority: P2 > Component: general > AssignedTo: fop-dev@xmlgraphics.apache.org > ReportedBy: med1...@gmail.com > Classification: Unclassified > > > The renderers rely on the FOUserAgent for configuration information, as > such, I > believe a cleaner interface would be to put the user-agent in the > constructor > of all the Renderers. This change would reduce the mutability of the > renderers > and go one step close to a cleaner interface. > > All the examples set the user-agent within a few lines of instantiating the > renderer. This gives more legitimacy for moving the user-agent to the > constructor. > > Although this is part of the "public" API, it's not part of the documented > API. > It does have a public access modifier, but almost all the FOP classes do. > I do > appreciate the arguments for backwards compatibility are valid, however, > FOP > can't stay beholden to a dated API solely for reasons of backwards > compatibility. The necessary changes made to any client code should be > simple. > > -- > Configure bugmail: > https://issues.apache.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug. >
