Thanks for bring these issues to my attention Chris. Revision 1240963 addresses all findbug and checkstyle warnings.
Thanks, Peter On Thu, Feb 2, 2012 at 11:56 AM, Chris Bowditch <bowditch_ch...@hotmail.com> wrote: > On 01/02/2012 15:40, Peter Hancock wrote: >> >> Hi All, > > > Hi Peter, > >> >> Vincent and I have recently been working to improve the generation of >> tagged PDF and we now propose merging the branch >> Temp_ImproveAccessibility into trunk. >> >> The objectives and an implementation plan was summarised by Vincent in >>  and development has remained fairly faithful to that proposal. >> >> A core objective of this work was to remove the XSLT pre-process stage >> and instead build the structure tree from FONode creation events and >> this has been realised. >> >> The new implementation has allowed us to fix a few bugs related to the >> structure tree representation of tables. > > > Looks like you've done some good work here. I checked out the code and > compiled it. I ran Findbugs and it reports 61 new warnins compared to trunk. > Please see the attached report. > > I have to vote -1 until the warnings are resolved. > > Thanks, > > Chris > > >> >> Thanks, >> >> Peter >> >>  >> http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-dev/201109.mbox/%3C4E6624CE.1030703%40gmail.com%3E >> >> >