Re: svn commit: r1339667 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java

[Luis Bernardo]

I was going to submit a fix myself. Anyway, the epsilon only needs to be 
1/256 because the fractional line width is stored in one byte. So it 
should be Math.abs(x - y) >= 1/256f.

On 5/17/12 5:53 PM, Vincent Hennebert wrote:
Hi Glenn,

This change introduces a dependency on Java 1.6. Please revert.

Thanks,
Vincent


On 17/05/12 16:53, gadams wrote:
Author: gadams
Date: Thu May 17 15:53:37 2012
New Revision: 1339667

URL: http://svn.apache.org/viewvc?rev=1339667&view=rev
Log:
Fix findbugs warning.

Modified:
     xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java

Modified: 
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java
URL: 
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java?rev=1339667&r1=1339666&r2=1339667&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java 
(original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java 
Thu May 17 15:53:37 2012
@@ -195,7 +195,8 @@ public class GraphicsObject extends Abst
       * @param lineWidth the line width multiplier
       */
      public void setLineWidth(float lineWidth) {
-        if (lineWidth != graphicsState.lineWidth) {
+        float epsilon = Float.MIN_NORMAL;
+        if ( Math.abs ( graphicsState.lineWidth - lineWidth )>  epsilon ) {
              addObject(new GraphicsSetFractionalLineWidth(lineWidth));
              graphicsState.lineWidth = lineWidth;
          }