On 18/07/2012 11:31, mehdi houshmand wrote:
I did create a bugzilla entry
(https://issues.apache.org/bugzilla/show_bug.cgi?id=53563), I just
didn't put the bug number in the commit message, my apologies, I was
complacent in that regard. Is it worth changing the commit message
retrospectively to add the bugzilla entry?
Thanks Mehdi - yes it is worth changing the commit message so that
anyone looking at that code in the future has full traceability.
Thanks,
Chris
Mehdi
On 18 July 2012 11:06, Chris Bowditch <[email protected]
<mailto:[email protected]>> wrote:
On 18/07/2012 10:12, [email protected] <mailto:[email protected]> wrote:
Hi Mehdi,
I thought we agreed all code changes should have a Bugzilla entry
opened for them? Can you create one retrospectively?
Thanks,
Chris
Author: mehdi
Date: Wed Jul 18 09:12:10 2012
New Revision: 1362823
URL: http://svn.apache.org/viewvc?rev=1362823&view=rev
Log:
Removed a method call that could cause a
java.awt.HeadlessException in PCLGraphics2D (brought it inline
with PDF/PS/AFP-Graphics2D classes)
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLGraphics2D.java
xmlgraphics/fop/trunk/status.xml
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLGraphics2D.java
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLGraphics2D.java?rev=1362823&r1=1362822&r2=1362823&view=diff
==============================================================================
---
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLGraphics2D.java
(original)
+++
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLGraphics2D.java
Wed Jul 18 09:12:10 2012
@@ -25,7 +25,6 @@ import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.awt.GraphicsConfiguration;
-import java.awt.GraphicsEnvironment;
import java.awt.Image;
import java.awt.Paint;
import java.awt.Shape;
@@ -44,6 +43,7 @@ import java.text.AttributedCharacterIter
import org.apache.xmlgraphics.java2d.AbstractGraphics2D;
import org.apache.xmlgraphics.java2d.GraphicContext;
+import
org.apache.xmlgraphics.java2d.GraphicsConfigurationWithTransparency;
import org.apache.xmlgraphics.util.UnitConv;
/**
@@ -127,8 +127,7 @@ public class PCLGraphics2D extends Abstr
/** {@inheritDoc} */
public GraphicsConfiguration getDeviceConfiguration() {
- return GraphicsEnvironment.getLocalGraphicsEnvironment()
-
.getDefaultScreenDevice().getDefaultConfiguration();
+ return new GraphicsConfigurationWithTransparency();
}
/**
Modified: xmlgraphics/fop/trunk/status.xml
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/status.xml?rev=1362823&r1=1362822&r2=1362823&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/status.xml (original)
+++ xmlgraphics/fop/trunk/status.xml Wed Jul 18 09:12:10 2012
@@ -63,6 +63,10 @@
documents. Example: the fix of marks layering will be
such a case when it's done.
-->
<release version="FOP Trunk" date="TBD">
+ <action context="Renderers" dev="MH" type="add"
fixes-bug="53563" importance="low">
+ Removed a method call to the
java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice()
+ that could (in a headless environment) throw a
java.awt.HeadlessException
+ </action>
<action context="Renderers" dev="VH" type="add"
importance="high">
When PDF accessibility is enabled, treat repeated
table headings as artifacts. This allows
screen readers to read the header only once at the
beginning of the table and the footer
---------------------------------------------------------------------
To unsubscribe, e-mail:
[email protected]
<mailto:[email protected]>
For additional commands, e-mail:
[email protected]
<mailto:[email protected]>