On 3/20/13 10:52 PM, Vincent Hennebert wrote:
On 19/03/13 00:49, Luis Bernardo wrote:
On 3/18/13 9:04 AM, Vincent Hennebert wrote:
<snip/>
xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/BlockContainerLayoutManager.java
(original)
+++
xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/BlockContainerLayoutManager.java
Sat Mar 16 00:27:00 2013
@@ -1040,6 +1040,9 @@ public class BlockContainerLayoutManager

       /** {@inheritDoc} */
       public boolean handleOverflow(int milliPoints) {
+        if (width.getEnum() == EN_AUTO) {
+            return false;
+        }
If the idea is to not issue a warning in this case, then it fails
because the warning will be issued by LineBreakingAlgorithm.updateData2
instead.


The idea was in fact the opposite. To issue a warning in a situation where it
made sense to do so but it was not happening. Simon had sent me an example but
I cannot find it now. Simon, can you attach the example?

In that case, I’m not too sure what the fact that the width has been
left to auto has to do with that. If the width has been set to some
value and text overflows, and the block is not absolutely positioned,
then still no warning will be issued. Or did I miss something?


<snip/>

Vincent
I did some more testing and I agree that this particular change can be reverted in trunk. It leads to a redundant message that is already taken care somewhere else in the code.

Reply via email to