[ 
https://issues.apache.org/jira/browse/FOP-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638052#comment-13638052
 ] 

Chris Bowditch commented on FOP-2210:
-------------------------------------

Hi Simon,

Thanks for your patch. There is no unit test present and it is recommended that 
you provide one. Also there are some checkstyle warnings, whilst not directly 
introduced by your changes, should be resolved since you change the line on  
which they occur, e.g. AddWord method in TextArea has a checkstyle warning 
about spaces after the brackets. You added a new parameter, which didn't cause 
the warning but as you are changing the same line I must insist you also 
resolve the checkstyle warning.

Thanks,

Chris
                
> [PATCH] Complex script IF to output missing glyphs
> --------------------------------------------------
>
>                 Key: FOP-2210
>                 URL: https://issues.apache.org/jira/browse/FOP-2210
>             Project: Fop
>          Issue Type: Bug
>            Reporter: simon steiner
>            Assignee: Chris Bowditch
>         Attachments: csspeedtrunk.patch, fop.xconf, test.fo
>
>
> fop test.fo -c fop.xconf -if application/pdf expected.if.xml
> fop -c fop.xconf -ifin expected.if.xml out.pdf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to