Max Gilead commented on FOP-2273:

As I mentioned in the previous comment: there should be two lines but Acrobat 
Reader shows only one. Do you see two diagonal lines in AR or only one?

Also, there is no error described above as I couldn't get it to display one 
with this simple example (the original PDF was generated using a 3rd party 
library) -- This is just a clarification as there is no error popup when 
opening the attached file yet the end result is the same -- the graphics 
rendering stops once Acrobat encounters a shape with a miter limit below 1.0

> Stroke miter limit is not clamped when writing PDFs
> ---------------------------------------------------
>                 Key: FOP-2273
>                 URL: https://issues.apache.org/jira/browse/FOP-2273
>             Project: Fop
>          Issue Type: Bug
>          Components: pdf
>    Affects Versions: trunk
>            Reporter: Max Gilead
>              Labels: easyfix
>         Attachments: FOP_Test.pdf, PDF-Rendering.png
> org.apache.fop.svg.PDFGraphics2D line 1240 (as of SVN revision 148001 [1]) is:
> float ml = bs.getMiterLimit();
> but should be (or equivalent):
> float ml = Math.max(1.0f, bs.getMiterLimit());
> Acrobat Reader (on all platforms) refuses to load graphics data after 
> encountering miter limit < 1.0 and reports an error.
> I can't find a reference to the valid range in the PDF spec but Inkscape also 
> had a problem with values less than 1.0 [2] and SVG spec mandates values >= 
> 1.0 as well [3] so clamping the value to 1.0 or more seems like the right 
> thing to do.
> [1] 
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphics2D.java?revision=1480018&view=markup
> [2] 
> http://webcache.googleusercontent.com/search?q=cache:RHSt5Wk7-uQJ:inkscape-forum.andreas-s.net/topic/71990+&cd=7&hl=en&ct=clnk&gl=uk&client=firefox-beta
> [3] http://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to