[
https://issues.apache.org/jira/browse/FOP-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790739#comment-13790739
]
Vincent Hennebert commented on FOP-2293:
----------------------------------------
Hi Seifeddine,
I can't apply your patch as it's missing new files (DynamicKnuthBox,
MultiCaseHandler, MultiCaseLayoutManager, etc.). Remember to svn add them
before creating the patch.
A few comments, just from reading the patch since I couldn't run it:
* BestFit.filter: why would you want to remove children FO nodes? Seems to me
like you just want to somehow select the right one.
* MultiCase.isActuated: are you sure about the test? Do you want to implement
this method at all? In the case of your extension there will be no actuation.
* MultiSwitch.finalizeNode: the selection of the best node cannot be done here?
You have to wait for the results of layout?
* MultiToggle: why do you implement a filter method in this class? From what I
understood you're not going to use that element in your extension. Therefore
you don't have to implement it. Otherwise you have to test it...
* if you could run Checkstyle before submitting your patch, that would help
more quickly apply it.
I'd say, forget about inline content for now, and have it working and tested
with just block content. At a next step you can concentrate on inline content.
At this point it would be good to have a layout test accompanying your patch.
That would serve two purposes: catch regressions, and document the
implementation of your extension. That would give us a sample with which we can
play and experiment. Have a look at the [developer
wiki|http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests] for
some information.
Thanks,
Vincent
> Whitespace management extension
> -------------------------------
>
> Key: FOP-2293
> URL: https://issues.apache.org/jira/browse/FOP-2293
> Project: Fop
> Issue Type: New Feature
> Components: general
> Affects Versions: trunk
> Reporter: Seifeddine Dridi
> Priority: Minor
> Labels: XSL-FO
> Fix For: trunk
>
> Attachments: bestfit.fo, doc.pdf, FO_multi-switch_test.fo,
> FO_multi-switch_with_best-fit_extension.patch, multiple-feasible-nodes.fo,
> multi-switch_bestfit.fo, patch.patch, patch-rev1.1.patch, patch-rev1.patch,
> patch-rev2.patch
>
>
> I have been working on an extension for whitespace management, similar to
> what's described here:
> http://wiki.apache.org/xmlgraphics-fop/WhitespaceManagement
> The logic of the extension is very simple: the user defines a set of
> alternatives that he wishes to insert at the end of a page, then if there is
> enough space left, FOP will pick the alternative that best matches the user's
> selection criteria (first fit, smallest fit, biggest fit).
> This is my first work on FOP and it took me almost 2 months to reach this
> stage in development. But it's not the end of course, so I'm relying on your
> feedback to improve it.
> Thank you
--
This message was sent by Atlassian JIRA
(v6.1#6144)
