[ 
https://issues.apache.org/jira/browse/FOP-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Meyer updated FOP-1069:
------------------------------

    Attachment: fix-20131203.diff

Sorry for my lateness with getting back to this issue. I looked at this briefly 
but didn't manage to update it before I went on an extended holiday to the US. 

The issue was caused by the validation line being placed within the loop for 
each property value component. For instance, the word "black" on border will 
result in a null property result, but the other parts may result in a property 
being returned. Because of this a warning was being displayed even if the 
property was found to be valid. As such, I have moved the line for validation 
outside of the loop and the check is now done after each component part has 
been processed rather than individually. A slight change is that using this 
method makes it impossible to identify which part of the property is at fault 
and so the values which can be read are added to a string and used in the 
warning e.g.

WARNING: Invalid property value encountered in border="black solit" (See 
position 11:46)

It should provide ample enough information to look at the line and fix the 
issue. On your original example it now works fine. I'll go ahead and commit 
this tomorrow unless you have any other comments.

> No error message on illegal/unknown values on a property
> --------------------------------------------------------
>
>                 Key: FOP-1069
>                 URL: https://issues.apache.org/jira/browse/FOP-1069
>             Project: Fop
>          Issue Type: Bug
>          Components: fo tree
>    Affects Versions: trunk
>         Environment: Operating System: All
> Platform: All
>            Reporter: Jeremias Maerki
>            Assignee: Robert Meyer
>         Attachments: fix-20131203.diff, patch.diff, test2.fo
>
>
> I've written border="solit 1pt" into an FO file. When I realized my typo I 
> went
> looking for an error message but didn't find one. I looked around to fix this
> myself but didn't find the right spot in reasonable time as I'm concentrating 
> on
> other stuff right now. I'm posting it here so it doesn't get lost.
> FOP should notify the user that it has found a value it cannot deal with,
> especially if this is an enum value.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to