[ https://issues.apache.org/jira/browse/FOP-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seifeddine Dridi updated FOP-2293: ---------------------------------- Attachment: FO_multi-switch_best-fit_ext_rev12.patch {quote} Are you talking about the value for auto-toggle here? "first-fit" makes sense but again, it might too easily be mistaken for one of the various layout methods (first fit, best fit, total fit). Maybe just "first-fitting"? {quote} I prefer something more explicit, like "select-first-fit". {quote} How easy would that be to simply show all of the multi-case children? It this is doable in a reasonable amount of time it should be done this way. What bothers me a bit right now is that the auto-toggle property is not used at all, so we have the extension behaviour by default. It would be better to trigger it only when auto-toggle is present. {quote} So if the auto-toggle property was not specified, we render all children of multi-switch. I've written an abstract class KnuthListGenerator which has two derived implementations: * DefaultKnuthListGenerator: returns a Knuth list of all FO multi-case. * WhitespaceManagement: returns {Box, WhitespaceManagementPenalty, Box} I guess everything is working fine now, but I have a concern regarding the case where the algorithm restarts at a MSLM position. If that happens, I think an exception will be thrown. Do you think that we should add a BreakElement at the end of the Knuth list? Thanks > Whitespace management extension > ------------------------------- > > Key: FOP-2293 > URL: https://issues.apache.org/jira/browse/FOP-2293 > Project: Fop > Issue Type: New Feature > Components: general > Affects Versions: trunk > Reporter: Seifeddine Dridi > Priority: Minor > Labels: XSL-FO > Fix For: trunk > > Attachments: FO_multi-switch_best-fit_ext_rev10.patch, > FO_multi-switch_best-fit_ext_rev11.patch, > FO_multi-switch_best-fit_ext_rev12.patch, > FO_multi-switch_best-fit_ext_rev2.patch, > FO_multi-switch_best-fit_ext_rev3.patch, > FO_multi-switch_best-fit_ext_rev4.patch, > FO_multi-switch_best-fit_ext_rev5.patch, > FO_multi-switch_best-fit_ext_rev6.patch, > FO_multi-switch_best-fit_ext_rev7.patch, > FO_multi-switch_best-fit_ext_rev8.patch, > FO_multi-switch_best-fit_ext_rev9.patch, FO_multi-switch_test.fo, > FO_multi-switch_with_best-fit_extension.patch, bestfit.fo, doc.pdf, > empty-last-page.fo, multi-switch-testcases.zip, multi-switch_bestfit.fo, > multiple-feasible-nodes.fo, patch-rev1.1.patch, patch-rev1.patch, > patch-rev2.patch, patch.patch, rev11_bug.fo, two-valid-variants.fo > > > I have been working on an extension for whitespace management, similar to > what's described here: > http://wiki.apache.org/xmlgraphics-fop/WhitespaceManagement > The logic of the extension is very simple: the user defines a set of > alternatives that he wishes to insert at the end of a page, then if there is > enough space left, FOP will pick the alternative that best matches the user's > selection criteria (first fit, smallest fit, biggest fit). > This is my first work on FOP and it took me almost 2 months to reach this > stage in development. But it's not the end of course, so I'm relying on your > feedback to improve it. > Thank you -- This message was sent by Atlassian JIRA (v6.2#6252)