Vincent Hennebert updated FOP-1099:

    Attachment: inverted-footnotes.pdf

Hi Matthias,

Thanks for your patch! I've applied it in [rev. 

I've made some modifications, essentially clean-up and javadoc, plus I added a 
test case and fixed one mistake: the KnuthBlockBox to add to the list when the 
header is repeated at page breaks should be of height 0, since the header 
height is already taken into account in headerAsSecondToLast.

I didn't apply Simon's patch as it has several faults. See attached files. For 
example the footnote from the header will be added after any footnote from the 
body (inverted-footnotes.fo). Or the footnote will be found at the very end of 
the page sequence instead of being on the same page as the table.

Those test cases are relatively simple, so I don't think we can proceed in this 
state. Basically the code that deals with footnotes in repeated table 
headers/footers doesn't integrate in the general footnote code, which can only 
cause issues.

The fact that repeated headers/footers are handled by using a penalty whose 
height corresponds to the additional heights of the header and footer will 
inevitably be a problem for obtaining the correct order of footnotes between 
the table header and the rest of the document.

So more work is needed, and the fact that the footnote code is extremely 
complex will make it... interesting :-)


> [PATCH] footnotes within tables and lists get lost
> --------------------------------------------------
>                 Key: FOP-1099
>                 URL: https://issues.apache.org/jira/browse/FOP-1099
>             Project: Fop
>          Issue Type: Bug
>          Components: layout/unqualified
>    Affects Versions: trunk
>         Environment: Operating System: other
> Platform: Other
>            Reporter: gerhard oettl
>         Attachments: 1044-tab-header-footnote-no-repeat.patch, 
> 1044-tab-header-footnote-no-repeat.xml, b37579.diff, b37579.diff, 
> b37579_2.patch, bugzilla37579.patch, dorfchronik.fo, dorfchronik.fo.list3, 
> dorfchronik.fo.table3, duplicated-footnote.fo, duplicated-footnote.pdf, 
> footnote-end-page-sequence.fo, footnote-end-page-sequence.pdf, 
> footnote-missing_page2.fo, footnote-missing_page2.pdf, footnote.fo, 
> footnoteintable.patch, footnotes.080502.diff, footnotespatch, fussnote.fo, 
> inverted-footnotes.fo, inverted-footnotes.pdf, table_list_footnotes.diff, 
> vtest.fo
> Footnote outside of tables works, inside table-cell not.
> The compliance page only speaks about restrictions within multicolumn 
> documents.

This message was sent by Atlassian JIRA

Reply via email to