[ 
https://issues.apache.org/jira/browse/FOP-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027661#comment-14027661
 ] 

Luis Bernardo commented on FOP-2385:
------------------------------------

Looks good. If a custom entry has an empty value it is added nevertheless, 
apparently against what is suggested in the spec. But since I believe the spec 
had the standard entries in mind, not custom ones, I think it makes sense to do 
it this way. +1 

> [PATCH] Add ability to specify custom properties in the Document Information 
> Dictionary
> ---------------------------------------------------------------------------------------
>
>                 Key: FOP-2385
>                 URL: https://issues.apache.org/jira/browse/FOP-2385
>             Project: Fop
>          Issue Type: Improvement
>          Components: renderer/pdf
>            Reporter: Vincent Hennebert
>            Assignee: Vincent Hennebert
>              Labels: patch
>         Attachments: pdf-custom-properties.patch
>
>
> It is possible to add custom key/value pairs in the Info dictionary of a PDF 
> document. Those custom properties will appear in the ‘Custom’ tab of Adobe 
> Reader’s ‘Document Properties’ window (not sure about other viewers though).
> This patch adds the possibility to do that. A pdf:info element can be added 
> as a child of fo:declarations and contain the custom properties. For example:
> {code:xml}
> <fo:declarations>
>   <pdf:info xmlns:pdf="http://xmlgraphics.apache.org/fop/extensions/pdf";>
>     <pdf:name key="MyProperty">MyValue</pdf:name>
>     <pdf:name key="MyOtherProperty">MyOtherValue</pdf:name>
>   </pdf:info>
> </fo:declarations>
> {code}
> Since it’s small, I thought that would be overkill to create a branch just 
> for that. So I’m putting it here for peer review.
> If nobody objects by 2014/06/12, I’m going to commit this patch to trunk.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to