[
https://issues.apache.org/jira/browse/FOP-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029103#comment-15029103
]
Andreas L. Delmelle edited comment on FOP-2455 at 11/26/15 9:28 PM:
--------------------------------------------------------------------
OK, done. Completely missed that the patch attached to the most recent mail was
different... Sorry.
So, to make sure I understand correctly, the additional identity check is just
to cover the case where both operands are null, right?
(Obviously, in case they are truly one and the same instance, this change will
even perform slightly better...)
EDIT - Note, just asking since, if this is not the reason, then maybe it is
because one of the component fields does not have a proper implementation for
equals, where it reverts to the default Object.equals() implementation, which
produces unexpected results (?)
was (Author: adelmelle):
OK, done. Completely missed that the patch attached to the most recent mail was
different... Sorry.
So, to make sure I understand correctly, the additional identity check is just
to cover the case where both operands are null, right?
(Obviously, in case they are truly one and the same instance, this change will
even perform slightly better...)
> [Patch] Duplicated AFP resource objects
> ---------------------------------------
>
> Key: FOP-2455
> URL: https://issues.apache.org/jira/browse/FOP-2455
> Project: FOP
> Issue Type: Bug
> Components: renderer/afp
> Affects Versions: trunk
> Reporter: Seifeddine Dridi
> Labels: patch
> Fix For: trunk
>
> Attachments: CZARN00, T1001252, fop.xconf, patch-updated.diff,
> patch.diff, test-fixed.afp, test.afp, test.fo
>
>
> When generating AFP documents, font resource objects are written as many
> times as the number of formatting objects in which they were used.
> This regression was introduced after a commit made Glenn Adams to fix
> FindBugs warnings (revision 1616590).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
