I prefer to know ASAP whether checkstyle or findbugs is broken, and having them in validate/verify phases supports this. Moving them to manual scripts (as was the case previously) is different to other Maven projects I've worked with and seems to encourage introducing new issues. Moving the phase of Findbugs seems like a fair compromise, I'll have a look into that tomorrow. Alternatively I can move FindBugs into its own profile which you have to explicitly enable.



On 29/03/2016 16:10, Glenn Adams wrote:

On Tue, Mar 29, 2016 at 1:59 AM, Simon Steiner <simonsteiner1...@gmail.com <mailto:simonsteiner1...@gmail.com>> wrote:


    After this change findbugs is always run for example: mvn clean
    install -DskipTests
    This doesn’t work on java 8 and takes much longer to run.

I agree with Simon. It is preferable to explicitly specify a findbugs goal when performing compile or install. The more standard process is to have findbugs run automatically when running the site phase.


    -----Original Message-----
    From: cbowdi...@apache.org <mailto:cbowdi...@apache.org>
    [mailto:cbowdi...@apache.org <mailto:cbowdi...@apache.org>]
    Sent: 24 March 2016 16:17
    To: fop-comm...@xmlgraphics.apache.org
    Subject: svn commit: r1736460 -

    Author: cbowditch
    Date: Thu Mar 24 16:16:47 2016
    New Revision: 1736460

    URL: http://svn.apache.org/viewvc?rev=1736460&view=rev
    Avoid the need to run checkstyle and findbugs separately and
    integrate them into the build process; checkstyle runs in validate
    (pre-compile) phase and findbugs runs in verify (post-compile) phase


    Modified: xmlgraphics/fop/trunk/fop-core/pom.xml
    --- xmlgraphics/fop/trunk/fop-core/pom.xml (original)
    +++ xmlgraphics/fop/trunk/fop-core/pom.xml Thu Mar 24 16:16:47 2016
    @@ -300,6 +300,7 @@
           <!-- code analysis - checkstyle -->
    + <groupId>org.apache.maven.plugins</groupId>
    @@ -311,6 +312,15 @@
    +        <executions>
    +          <execution>
    +            <id>validate</id>
    +            <phase>validate</phase>
    +            <goals>
    +              <goal>check</goal>
    +            </goals>
    +          </execution>
    +        </executions>
           <!-- code analysis - findbugs -->
    @@ -322,6 +332,15 @@
    +        <executions>
    +          <execution>
    +            <id>verify</id>
    +            <phase>verify</phase>
    +            <goals>
    +              <goal>check</goal>
    +            </goals>
    +          </execution>
    +        </executions>

    To unsubscribe, e-mail:
    For additional commands, e-mail:

Reply via email to