[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327009#comment-15327009
 ] 

Martin Leitner commented on FOP-2536:
-------------------------------------

Matthias: I attached a sample fo file, together with the pdfs as generated by 
FOP 2.0, FOP 2.1, and my patched version.

Note that technically they are identical, since FOP generated the borders 
correctly all the time. It is only the (broken) readers that have problems. The 
pdfs look all the same to me in Foxit Reader. In Adobe Reader (version 11.0.2) 
however, the top border of the spanned cell appears broken even without any 
zoom. I attached a screenshot.
It appears that the problem only shows with borders of spanned cells that have 
non-spanned neighbouring cells, at least in this version of Adobe Reader.

I understand that every attempt to fix this issue in the renderer can at best 
be incomplete, since it is close to impossible to test the behaviour of all 
readers in all cases. Therefor it is perfectly possible and even likely that 
there are better approaches than mine. What I don't understand is why there is 
no reaction to this topic. There is not even any acknowledgement that the 
problem exists, even though it exists for years, much less any comment on the 
offered solution. How hard can it be to check if the proposed patch passes the 
existing unit tests, for a start?

> [PATCH] Varying table border thickness in PDF output
> ----------------------------------------------------
>
>                 Key: FOP-2536
>                 URL: https://issues.apache.org/jira/browse/FOP-2536
>             Project: FOP
>          Issue Type: Improvement
>          Components: renderer/pdf
>            Reporter: Martin Leitner
>         Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to