[
https://issues.apache.org/jira/browse/FOP-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960435#comment-15960435
]
Chris Bowditch commented on FOP-616:
------------------------------------
I spoke too soon. I went to run the unit tests and discovered an issue with
your patch. It doesn't handle the new Trait in the AT/IF XML. Whilst looking
into that I also noticed that the Visibility Trait Enum did not follow the same
convention as the others. I rewrote the Visibility Enum class to extend
EnumTrait. However, it still needs more work to handle this trait in the AT/IF
XML.
Sorry its taken 5 years to get feedback on your patch.
> [PATCH] "visibility" property is not implemented
> ------------------------------------------------
>
> Key: FOP-616
> URL: https://issues.apache.org/jira/browse/FOP-616
> Project: FOP
> Issue Type: Bug
> Components: unqualified
> Affects Versions: trunk
> Environment: Operating System: other
> Platform: Other
> Reporter: Martin Aubele
> Assignee: Chris Bowditch
> Attachments: FOP616.patch, visibility.patch
>
>
> The property visibility is not implemented.
> I would need especially the visibility="hidden" behavior for block elements.
> Proposal for the fix for Block:
> 1. Change the definition of the visiblity property in foproperties.xml
> to:
> <property>
> <name>visibility</name>
> <inherited>false</inherited>
> <!--
> original code:
> <datatype>ToBeImplemented</datatype>
> <default>visible</default>
> changed my [email protected]
> -->
> <datatype>Enum</datatype>
> <enumeration>
> <value const="VISIBLE">visible</value>
> <value const="HIDDEN">hidden</value>
> <value const="COLLAPSE">collapse</value>
> <value const="INHERIT">inherit</value>
> </enumeration>
> </property>
> 2. Put the following line at the beginning of Block#layout:
> Property visibility = this.properties.get("visibility");
> if (visibility != null && visibility.getEnum() == Visibility.HIDDEN)
> return new Status(OK);
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
