JC created FOP-2732:
-----------------------

             Summary: Collection added to itself
                 Key: FOP-2732
                 URL: https://issues.apache.org/jira/browse/FOP-2732
             Project: FOP
          Issue Type: Bug
            Reporter: JC
            Priority: Trivial


Hi 

In a recent github mirro, I've found the following suspicious code.
Branch: master
Path: 
fop-core/src/main/java/org/apache/fop/afp/goca/AbstractGraphicsDrawingOrderContainer.java

{code:java}
...
 39     protected List objects = new java.util.ArrayList();
...
 86     public void addAll(AbstractGraphicsDrawingOrderContainer 
graphicsContainer) {
 87         Collection objects = graphicsContainer.getObjects();
 88         objects.addAll(objects);
 89     }
{code}

In Line 88, should `objects.addAll' be `*this*.objects.addAll? Since this 
method in an abstract class, it might not be an issue if this method is 
overridden. However, I wanted to report this just in case.

Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to