[
https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446489#comment-16446489
]
William Eliot Kimber edited comment on FOP-1760 at 4/20/18 11:09 PM:
---------------------------------------------------------------------
I'm trying to use this patch against the 2.2.0 version the patch was made for.
To make it work I had to add fo:change-bar-begin and fo:change-bar-end to
isInlineItem() in FObj.java:
{{ && ("bidi-override".equals(lName)}}
{{ || "change-bar-begin".equals(lName)}}
{{ || "change-bar-end".equals(lName)}}
{{ || "character".equals(lName)}}
Otherwise I got a validation failure.
Since the last patch is behind dev I'm not sure how best to prepare an updated
patch (I've forgotten what little SVN fu I once had and I've never really had
to deal with patches in my career as a developer).
Assuming the code works as it should, I'd really like to see this make it into
the next appropriate FOP release. I'm in a position to do whatever development
work is required, such as bringing tests up to date, adding more tests, etc.
was (Author: drmacro):
I'm trying to use this patch against the 2.2.0 version the patch was made for.
To make it work I had to add fo:change-bar-begin and fo:change-bar-end to
isInlineItem() in FObj.java:
```
&& ("bidi-override".equals(lName)
|| "change-bar-begin".equals(lName)
|| "change-bar-end".equals(lName)
|| "character".equals(lName)
```
Otherwise I got a validation failure.
Since the last patch is behind dev I'm not sure how best to prepare an updated
patch (I've forgotten what little SVN fu I once had and I've never really had
to deal with patches in my career as a developer).
Assuming the code works as it should, I'd really like to see this make it into
the next appropriate FOP release. I'm in a position to do whatever development
work is required, such as bringing tests up to date, adding more tests, etc.
> [PATCH] FOP doesn't support change bar generation
> -------------------------------------------------
>
> Key: FOP-1760
> URL: https://issues.apache.org/jira/browse/FOP-1760
> Project: FOP
> Issue Type: New Feature
> Components: unqualified
> Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
> Reporter: Stephan Thesing
> Priority: Blocker
> Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff,
> changebar_20110308.diff, changebars.fo, changebars.pdf,
> changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt,
> fop_20120507.diff, fop_changebars_20120506.diff,
> patch_against_rev_1686494_2015-06-19.patch,
> patch_against_rev_1690781_2015-07-19.patch,
> patch_against_rev_1755460_2016-08-07.patch,
> patch_against_rev_1776640_2016-12-30.patch, test.fo, test.pdf
>
>
> In order to produce change bars along the columns for changed contents,
> FO supports the fo:change-bar-begin and fo:change-bar-end elements.
> These are not supported by FOP.
> Support for change bars should be added.
> Effort needed
> - add parsing and validation of fo: elements
> - determine fo elements under influence of one or more change bars
> - when creating areas from such affected fo elements, create additional areas
> representing the change bars as defined in the FO standard.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
