Christopher Thumberger created FOP-3145:
-------------------------------------------

             Summary: [PATCH] Fix creating empty GAD fields when embedding GOCA 
objects greater than 8192 bytes in size in AFP
                 Key: FOP-3145
                 URL: https://issues.apache.org/jira/browse/FOP-3145
             Project: FOP
          Issue Type: Bug
            Reporter: Christopher Thumberger
         Attachments: EmptyGADFields.patch, image-2023-08-23-16-51-11-519.png, 
image-2023-08-23-16-53-06-714.png

When a GraphicsData object would exceed 8200 bytes in size, instead of moving 
the last area of GOCA data to a new GraphicsData and continuing from there, FOP 
currently moves the data into a new GraphicsData object, leaving the old one 
empty. This is technically not a violation of MODCA spec, but has caused 
crashes in AFP viewer software. My patch prevents GAD fields ever exceedining 
8200 bytes and prevents GOCA instructions being cut up between segments.

Below is an example of the current behaviour as of FOP 2.8 visualized with 
AFPExplorer and my fixed version with the same input data.

!image-2023-08-23-16-51-11-519.png!
!image-2023-08-23-16-53-06-714.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to